Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] edi_edifact_oca #19

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[16.0][ADD] edi_edifact_oca #19

merged 1 commit into from
Oct 24, 2023

Conversation

QuocDuong1306
Copy link
Contributor

@QuocDuong1306 QuocDuong1306 commented Sep 21, 2023 •
edited by yvaucher
Loading

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_edifact_oca branch from a249fbc to 71b2f70 Compare September 21, 2023 05:18
simahawk
simahawk requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on OCA/edi#813 the dependencies have to be fixed.
THIS module here is the on that should plug the party data module.

edi_oca/__manifest__.py Outdated Show resolved Hide resolved
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_edifact_oca branch 2 times, most recently from 07598ab to f862559 Compare October 3, 2023 08:56
@QuocDuong1306 QuocDuong1306 marked this pull request as draft October 3, 2023 09:03
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_edifact_oca branch 3 times, most recently from 7359928 to c90cbf3 Compare October 9, 2023 04:34
simahawk
simahawk requested changes Oct 10, 2023
View reviewed changes
edi_edifact_oca/components/party_data.py Show resolved Hide resolved
edi_edifact_oca/tests/test_party_data.py Outdated
)

def test_lookup_default(self):
provider = get_party_data_component(self.exc_record_no_edifact, self.partner)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not testing at all your the code of this module... you are testing the base component... seems useless.

edi_edifact_oca/models/edifact.py Outdated Show resolved Hide resolved
@nilshamerlinck nilshamerlinck mentioned this pull request Oct 10, 2023
Merged
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_edifact_oca branch 2 times, most recently from a009ba5 to 3b9f49f Compare October 17, 2023 05:34
@QuocDuong1306 QuocDuong1306 marked this pull request as ready for review October 17, 2023 07:07
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-add-edi_edifact_oca branch from 3b9f49f to 5440315 Compare October 19, 2023 09:39
@yvaucher yvaucher mentioned this pull request Oct 19, 2023
Merged
yvaucher
yvaucher approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-19-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6cb52a4 into OCA:16.0 Oct 24, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6bc6355. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuocDuong1306 @simahawk @OCA-git-bot @yvaucher